Skip to content
This repository has been archived by the owner on Jun 11, 2024. It is now read-only.

Fix export microservice #2016

Merged
merged 26 commits into from
Jan 29, 2024
Merged

Fix export microservice #2016

merged 26 commits into from
Jan 29, 2024

Conversation

sameersubudhi
Copy link
Contributor

@sameersubudhi sameersubudhi commented Jan 25, 2024 •
edited
Loading

What was the problem?

This PR resolves #2014

How was it solved?

  • Add microservice dependencies for the export microservice
  • Allow slack in index readiness when scheduling jobs
  • Avoid scheduling duplicate jobs
  • Auto reschedule jobs in case of job timeouts
  • Improved logging
  • Refactor/Optimize code to reduce unnecessary calls to the connector/indexer from the export microservice
  • Add prefix handling in event topics for transactionID/ccmID
  • Fix old/add new unit tests

How was it tested?

Locally and 3 server instances against the mainnet.

@sameersubudhi sameersubudhi self-assigned this Jan 25, 2024
github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 25, 2024
View reviewed changes
services/blockchain-connector/shared/sdk/token.js Dismissed Show dismissed Hide dismissed
services/blockchain-connector/shared/sdk/token.js Dismissed Show dismissed Hide dismissed
@codecov Codecov
Copy link

codecov bot commented Jan 25, 2024 •
edited
Loading

Codecov Report

Attention: 57 lines in your changes are missing coverage. Please review.

Comparison is base (559d266) 68.02% compared to head (a551dfa) 68.33%.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development    #2016      +/-   ##
===============================================
+ Coverage        68.02%   68.33%   +0.30%     
===============================================
  Files              299      300       +1     
  Lines             5336     5429      +93     
  Branches           975      991      +16     
===============================================
+ Hits              3630     3710      +80     
- Misses            1706     1719      +13
Files Coverage Δ
...shared/dataService/business/token/accountExists.js 100.00% <100.00%> (+68.75%) ⬆️
.../shared/dataService/business/token/availableIDs.js 53.84% <100.00%> (ø)
...es/blockchain-indexer/shared/utils/transactions.js 100.00% <100.00%> (ø)
services/export/config.js 100.00% <ø> (ø)
services/export/shared/helpers/chain.js 73.91% <100.00%> (+2.48%) ⬆️
services/export/shared/helpers/constants.js 100.00% <100.00%> (ø)
services/export/shared/helpers/index.js 100.00% <100.00%> (ø)
services/export/shared/helpers/time.js 100.00% <100.00%> (ø)
services/gateway/tests/constants/utils.js 100.00% <ø> (ø)
services/export/shared/helpers/ready.js 96.96% <96.96%> (ø)
... and 1 more

nagdahimanshu
nagdahimanshu approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@nagdahimanshu nagdahimanshu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as expected 🚀

@sameersubudhi sameersubudhi merged commit a752ea6 into development Jan 29, 2024
9 of 10 checks passed
@sameersubudhi sameersubudhi deleted the 2014-fix-export-microservice branch January 29, 2024 09:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@nagdahimanshu nagdahimanshu nagdahimanshu approved these changes

Assignees

@sameersubudhi sameersubudhi

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Fix export microservice
2 participants
@sameersubudhi @nagdahimanshu